Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes fixes #421

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Aug 1, 2024

What does this PR change?

Fixes:

  • cert-manager deprecated CRDs installation parameter
  • uninstallation of traefik to properly reload without our config
  • Output more command outputs to the log file
  • Fix uninstallation of the server on kubernetes looking for the proxy helm release.

Test coverage

  • No tests: could only be covered with end to end tests

  • DONE

Links

Issue(s): #

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

When removing the configuration file traefik is not reinstalled. This
can be achieved by change the file to an empty one and deleting it once
traefik has been reinstalled.
@cbosdo cbosdo requested a review from mbussolotto August 1, 2024 07:07
Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nadvornik nadvornik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants