Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable signals to have fine-grained validations #2888

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat: enable signals to have fine-grained validations #2888

wants to merge 43 commits into from
+1,786 −59

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Nov 4, 2024 •
edited
Loading

Description

This adds the API for adding fine-grained validators for different signal operations.
Fixes #2835

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

taefi and others added 20 commits October 29, 2024 11:18
@taefi
add validators for removal and insertion in ListSignal
dab3deb
@taefi
add missing return
e4c6bb7
@taefi
fix createSnapshotEvent to utilize the delegate instance
b659c36
@taefi
formatter:format
f977075
@taefi
fix createSnapshotEvent to utilize the delegate instance properly
a6668b7
@taefi
consider delegate in subscription to ListSignal
b68a2bc
@taefi
add some tests for ListSignal withInsertionValidator
f9bf44e
@cromoteca
Add delegation to number and value signal
652d959
@cromoteca
Add operations
9a9021e
@taefi
add tests for ListSignal withRemovalValidator
4c9a6ae
@taefi
add composite tests for structural operation validators
2a31305
@cromoteca
Add test with two operations
b78c890
@taefi
add withItemSetValueValidator and withItemReplaceValueValidator opera…
963daef 
…tions
@taefi
Merge remote-tracking branch 'origin/collab/signal-validators' into c…
46e1136 
…ollab/signal-validators
@cromoteca
Refactor delegate
4fc4944
@taefi
refine operations validators for items and add tests
a31e3bb
@taefi
refine operation validators for items and add tests
fb7bc3c
@taefi
refactor duplicate code
b8e2cde
@taefi
fix the notify users functionality
a6ff093
@taefi
add tests
e5d429e
@taefi taefi changed the title Collab/signal validators feat: enable signals to have fine-grained validations Nov 4, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (64716cb) to head (3102dc8).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2888   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          83       83           
  Lines        2831     2831           
  Branches      729      729           
=======================================
  Hits         2623     2623           
  Misses        156      156           
  Partials       52       52
Flag Coverage Δ
unittests 92.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review November 6, 2024 23:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable fine-grained access control for full-stack signals
3 participants
@taefi @cromoteca @platosha