Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable signals to have fine-grained validations #2888

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat: enable signals to have fine-grained validations #2888

wants to merge 43 commits into from

Commits on Oct 29, 2024

  1. add validators for removal and insertion in ListSignal

    @taefi
    taefi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    dab3deb View commit details
    Browse the repository at this point in the history

  2. add missing return

    @taefi
    taefi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e4c6bb7 View commit details
    Browse the repository at this point in the history

  3. fix createSnapshotEvent to utilize the delegate instance

    @taefi
    taefi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b659c36 View commit details
    Browse the repository at this point in the history

  4. formatter:format

    @taefi
    taefi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f977075 View commit details
    Browse the repository at this point in the history

  5. fix createSnapshotEvent to utilize the delegate instance properly

    @taefi
    taefi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a6668b7 View commit details
    Browse the repository at this point in the history

  6. consider delegate in subscription to ListSignal

    @taefi
    taefi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b68a2bc View commit details
    Browse the repository at this point in the history

  7. add some tests for ListSignal withInsertionValidator

    @taefi
    taefi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f9bf44e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Add delegation to number and value signal

    @cromoteca
    cromoteca committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    652d959 View commit details
    Browse the repository at this point in the history

  2. Add operations

    @cromoteca
    cromoteca committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9a9021e View commit details
    Browse the repository at this point in the history

  3. add tests for ListSignal withRemovalValidator

    @taefi
    taefi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4c9a6ae View commit details
    Browse the repository at this point in the history

  4. add composite tests for structural operation validators

    @taefi
    taefi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2a31305 View commit details
    Browse the repository at this point in the history

  5. Add test with two operations

    @cromoteca
    cromoteca committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b78c890 View commit details
    Browse the repository at this point in the history

  6. add withItemSetValueValidator and withItemReplaceValueValidator opera… 

    …tions
    @taefi
    taefi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    963daef View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/collab/signal-validators' into c… 

    …ollab/signal-validators
    @taefi
    taefi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    46e1136 View commit details
    Browse the repository at this point in the history

  8. Refactor delegate

    @cromoteca
    cromoteca committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4fc4944 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. refine operations validators for items and add tests

    @taefi
    taefi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a31e3bb View commit details
    Browse the repository at this point in the history

  2. refine operation validators for items and add tests

    @taefi
    taefi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fb7bc3c View commit details
    Browse the repository at this point in the history

  3. refactor duplicate code

    @taefi
    taefi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b8e2cde View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. fix the notify users functionality

    @taefi
    taefi committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a6ff093 View commit details
    Browse the repository at this point in the history

  2. add tests

    @taefi
    taefi committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e5d429e View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'main' into collab/signal-validators

    @taefi
    taefi authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    9102760 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Add interface to operations to share value

    @cromoteca
    cromoteca committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b39c02d View commit details
    Browse the repository at this point in the history

  2. add generic withValidator methods

    @taefi
    taefi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f511e8b View commit details
    Browse the repository at this point in the history

  3. formatter:format

    @taefi
    taefi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1539b38 View commit details
    Browse the repository at this point in the history

  4. add asReadonly method

    @taefi
    taefi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1fa1830 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'main' into collab/signal-validators

    @cromoteca
    cromoteca committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    cfcd85a View commit details
    Browse the repository at this point in the history

  2. Remove HasValue as not used

    @cromoteca
    cromoteca committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0954a69 View commit details
    Browse the repository at this point in the history

  3. refactor asReadonly

    @taefi
    taefi committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    95fee17 View commit details
    Browse the repository at this point in the history

  4. Format code

    @cromoteca
    cromoteca committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    37922ec View commit details
    Browse the repository at this point in the history

  5. Remove single operation validators

    @cromoteca
    cromoteca committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    07b050c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into collab/signal-validators

    @cromoteca
    cromoteca authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    02c00be View commit details
    Browse the repository at this point in the history

  7. Minor refactorings

    @cromoteca
    cromoteca committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a9e3f92 View commit details
    Browse the repository at this point in the history

  8. Add OperationValidator

    @cromoteca
    cromoteca committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0ad9741 View commit details
    Browse the repository at this point in the history

  9. Make SignalOperation generic

    @cromoteca
    cromoteca committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5e18f98 View commit details
    Browse the repository at this point in the history

  10. add ListSignal tests

    @taefi
    taefi committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    42d6823 View commit details
    Browse the repository at this point in the history

  11. add tests for ValueSignal

    @taefi
    taefi committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5cbf6d5 View commit details
    Browse the repository at this point in the history

  12. simplify validated signals

    @taefi
    taefi committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8846ff2 View commit details
    Browse the repository at this point in the history

  13. add tests for NumberSignal validators

    @taefi
    taefi committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ec0beb0 View commit details
    Browse the repository at this point in the history

  14. refactor ValidationResult methods and add javadocs

    @taefi
    taefi committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    dd63ab8 View commit details
    Browse the repository at this point in the history

  15. remove commented code

    @taefi
    taefi committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    07b71f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge branch 'main' into collab/signal-validators

    @taefi
    taefi authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    826241d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Merge branch 'main' into collab/signal-validators

    @taefi
    taefi authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    37ffb45 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Merge branch 'main' into collab/signal-validators

    @platosha
    platosha authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3102dc8 View commit details
    Browse the repository at this point in the history