refactor: simplify hilla-bom #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZheSun88
force-pushed
the
simplify-hilla-bom
branch
from
d01ace0
to
1d627ad
Compare
ZheSun88
force-pushed
the
simplify-hilla-bom
branch
from
1d627ad
to
6bb6c0c
Compare
Artur-
previously approved these changes
Mar 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2160 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 64 64
Lines 1622 1622
Branches 364 364
=======================================
Hits 1521 1521
Misses 66 66
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZheSun88
force-pushed
the
simplify-hilla-bom
branch
from
6ae28ce
to
795e533
Compare
|
Artur-
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nowadays, hilla-bom is not a separated bom that user will use directly. so we dont need to provide dependencies like
also fixes #2158