Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ssubscribe command #178

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

fix ssubscribe command #178

wants to merge 16 commits into from

Conversation

VyacheslavVanin
Copy link

@VyacheslavVanin VyacheslavVanin commented Mar 10, 2025 •
edited
Loading

Support ssubscribe command

Relates: #177

@VyacheslavVanin
fix ssubscribe command
028ff20 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
fix clang-format
db471ad 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
fix tests (added one allocation in dict)
dfc3478 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@bjosv
Copy link
Collaborator

bjosv commented Mar 11, 2025

Thanks!
It would be great if we could add a test, but I'm not sure if we have any slots assigned when running client_test.c.. test_pubsub_handling_resp3 could be a good starting point in that case.

In comparison to subscribe and psubscribe the ssubscribe command can return -MOVED. Do we just return this response to the user or how is it handled?

@VyacheslavVanin
Add tests on ssubscribe
606c416 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
Copy link
Author

Yes, you are right. I wanted that MOVED just be returned to users, but seems like a callback is not called in case of error.
I will try to fix this

@VyacheslavVanin
add error handling
6beba33 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
fix leak
b0e2417 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
fix comment style
0bf9924 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
remove redundant commented code
fe28987 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
add config for cluster tcp connections
99f2cbe 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
Fix memmory-overrun
33a1d70 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
revert accidential changes
9a401c8 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
fix
5fab92c 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
Fix spelling
e7ed20f 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
Do not run cluster tests if there is no cluster
97fd960 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
fix build
221225a 
Signed-off-by: Vyacheslav Vanin <[email protected]>
@VyacheslavVanin
Copy link
Author

I turned off sharded_pubsub_test in ci-workflows that don’t run clusters

@VyacheslavVanin
fix typo
109ce80 
Signed-off-by: Vyacheslav Vanin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VyacheslavVanin @bjosv