Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add execution info to README #143

Merged
merged 2 commits into from
Jan 7, 2025
Merged

📝 Add execution info to README #143

merged 2 commits into from
Jan 7, 2025

Conversation

teroyks
Copy link
Contributor

@teroyks teroyks commented Jan 7, 2025

Documents #141

Add an example of using valohai.execution().config.

Also contains some formatting fix ups to bring the README up to snuff.

Fix minor things such as:

- spacing after headings

- proper headings hierarchy

- missing code block language setting

  - use more generic `shell` instead of `bash`
    when no bash-specific syntax is used
Fetch ID, title, and counter from the current execution.
@teroyks teroyks added the documentation Improvements or additions to documentation label Jan 7, 2025
@teroyks teroyks self-assigned this Jan 7, 2025
@teroyks teroyks requested review from hylje and noorula January 7, 2025 13:06
@teroyks teroyks marked this pull request as ready for review January 7, 2025 13:07
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, it has been improved

Comment on lines +176 to +188
## Execution Info

`valohai.execution` contains information about the current execution context.

```python
import valohai

execution_config = valohai.execution().config
print(f"Execution ID: {execution_config.id}")
print(f"Execution title: {execution_config.title}")
print(f"Execution counter: {execution_config.counter}")
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small note how they behave outside of Valohai might be nice but maybe sometime later 👍️

@teroyks teroyks merged commit e671b4f into master Jan 7, 2025
5 checks passed
@teroyks teroyks deleted the readme-update branch January 7, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants