Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #144

Merged
merged 3 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ name: CI

jobs:
Test:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.7"
python-version: "3.8"
cache: pip
cache-dependency-path: '**/setup.cfg'
- name: Install
Expand All @@ -29,7 +29,7 @@ jobs:
- name: Test with pytest
run: pytest -ra --cov .
Typecheck:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Set up Python
Expand All @@ -42,13 +42,13 @@ jobs:
run: python -m pip install -r requirements-typecheck.txt -e .
- run: mypy --strict .
Lint:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: pre-commit/[email protected]
Build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Set up Python
Expand All @@ -69,7 +69,7 @@ jobs:
needs:
- Build
name: Upload release to PyPI
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment:
name: release
url: https://pypi.org/p/valohai-utils/
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = "valohai-utils"
dynamic = ["version"]
readme = "README.md"
license = "MIT"
requires-python = ">=3.7"
requires-python = ">=3.8"
authors = [
{ name = "Valohai", email = "[email protected]" },
]
Expand All @@ -32,7 +32,7 @@ packages = [


[tool.ruff]
target-version = "py37"
target-version = "py38"

[tool.ruff.lint]
ignore = [
Expand Down
1 change: 1 addition & 0 deletions requirements-dev.in
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
pytest-cov
requests-mock
valohai-cli
valohai-yaml>=0.46.0 # required for stable YAML generation
4 changes: 3 additions & 1 deletion tests/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import glob
import json
import os
import pytest

from difflib import unified_diff as diff

Expand Down Expand Up @@ -75,10 +76,11 @@ def read_yaml_test_data(root_path):
dirname = os.path.dirname(source_path)
name, extension = os.path.splitext(os.path.basename(source_path))
test_data.append(
(
pytest.param(
f"{dirname}/{name}.original.valohai.yaml",
source_path,
f"{dirname}/{name}.expected.valohai.yaml",
id=f"{dirname}/{name}",
)
)
return test_data
Expand Down
Loading