Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording. #256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix wording. #256

wants to merge 1 commit into from

Conversation

ZevEisenberg
Copy link

I don't think "high-performant" is a thing. I figure "high-performance" was intended. But maybe it was intentional?

@ZevEisenberg ZevEisenberg requested a review from 0xTim as a code owner February 27, 2025 22:22
@0xTim
Copy link
Member

0xTim commented Feb 27, 2025

It was deliberate. Performant is the adjective of performance, so describes the APIs as having high performance

@ZevEisenberg
Copy link
Author

I'm not the only one who was surprised by this. It was a usage I, as a native speaker, had never heard before. But I'm not a prescriptivist. As long as it's intentional, who am I to say it's wrong?

@zastrozzi
Copy link

Both OED and Cambridge now consider it a word, particularly in a technology-related context. Out of interest though, it's first known usage isn't tech-related at all - Samuel Coleridge used it in the 19th century

@ZevEisenberg
Copy link
Author

Both OED and Cambridge now consider it a word, particularly in a technology-related context. Out of interest though, it's first known usage isn't tech-related at all - Samuel Coleridge used it in the 19th century

It looks like that first usage is an obsolete definition meaning "the person who performs something," similar to "referent" or "defendant".

@zastrozzi
Copy link

Not to get into a linguistic squabble but... the verb+ant form of many roots can be used as both noun and adjective.

Note that this isn't the case for referent as it is direct from the Latin referent however for defendant both usages are valid.

See https://www.merriam-webster.com/dictionary/defendant

I would post OED's corroboration but it's paywalled unfortunately.

@zastrozzi
Copy link

zastrozzi commented Mar 1, 2025

Though really we're not comparing apples anyway. A change from high-performant to either performant or high-performance is probably valid.

Specialisation of an adjectival form via hyphenation is either obsolete when the adjectival form (performant) already supplies an affirmation or misleading if it attempts to further qualify it (e.g. low-performant does not make sense)

@gwynne
Copy link
Member

gwynne commented Mar 1, 2025

FWIW, I think this is a valid change - "performant" is a valid adjectival form, but in this context "performance" is more grammatically idiomatic. (Try saying that five times fast...)

@ZevEisenberg
Copy link
Author

Yaaay the language nerds have come out to play! I think Gwynne's point about it being idiomatic is the best summary of what I was going for. "High-performant" just isn't a common wording, whereas "high-performance" is. (It's also a lot of syllables to say "fast," but I guess it's idiomatic for computer stuff?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants