Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine Leaf cache documentation #1053

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Refine Leaf cache documentation #1053

merged 2 commits into from
Jan 17, 2025

Conversation

alemohamad
Copy link
Member

Added an improvement for the cache documentation, as discussed at #850 (comment).

@alemohamad alemohamad added the translation-update This PR contains translations for the docs label Jan 15, 2025
@alemohamad alemohamad self-assigned this Jan 15, 2025
0xTim
0xTim approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim
Copy link
Member

0xTim commented Jan 17, 2025

Removing the translation-update as we should update the other translations as well

@alemohamad alemohamad added updates Adding new or updated documentation. and removed translation-update This PR contains translations for the docs labels Jan 17, 2025
@alemohamad
Copy link
Member Author

Removing the translation-update as we should update the other translations as well

@0xTim having the tag updates will trigger the issue with new content to be translated?

@0xTim
Copy link
Member

0xTim commented Jan 17, 2025

Removing the translation-update as we should update the other translations as well

@0xTim having the tag updates will trigger the issue with new content to be translated?

Any PR that is closed without the translation-update or no-update-needed will trigger the workflow

@0xTim 0xTim merged commit 4e68a52 into vapor:main Jan 17, 2025
1 check passed
@penny-for-vapor penny-for-vapor bot mentioned this pull request Jan 17, 2025
Open
9 tasks
@alemohamad alemohamad deleted the refine-leaf-cache-documentation branch January 17, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees

@alemohamad alemohamad

Labels
updates Adding new or updated documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alemohamad @0xTim