Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency updates and database logging APIs #775

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 30, 2024

These changes are now available in 4.11.0

This update contains the following changes:

  • Two new APIs are available: Application.db(_:logger:) and Request.db(_:logger:). These work exactly the way the respective .db(_:) methods do, except the database's logger will be set to the one provided rather than the default. These APIs will hopefully make it easier to work around the unfortunate fact that Database.logging(to:) and its SQLKit counterpart basically don't work at all.
  • The --auto-migrate and --auto-revert commandline flags no longer call EventLoopFuture.wait() when the app is booted in async mode (no more crash risk).
  • The migrate command now has nicer console output.
  • All tests have been updated to be fully async.

@gwynne gwynne added enhancement New feature or request semver-minor Contains new APIs labels May 30, 2024
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy May 30, 2024 05:56
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 65.78947% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 60.75%. Comparing base (d831ac5) to head (d3579e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   59.84%   60.75%   +0.91%     
==========================================
  Files          15       15              
  Lines         381      372       -9     
==========================================
- Hits          228      226       -2     
+ Misses        153      146       -7     
Files Coverage Δ
Sources/Fluent/MigrateCommand.swift 8.33% <0.00%> (+1.51%) ⬆️
Sources/Fluent/FluentProvider.swift 71.08% <78.12%> (-7.49%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwynne gwynne merged commit dfcbeba into main May 30, 2024
9 checks passed
@gwynne gwynne deleted the concurrency-update branch May 30, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-minor Contains new APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants