chore: bump Svelte example to Svelte v5 #9981
Open
+1,662
−1,816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@joshnuss is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
joshnuss
changed the title
|
This looks good - except the lockfile needs to be updated! Once you do that, we can merge it. 👍 |
|
@anthonyshew Updated the lockfile. |
|
Thanks! I'm seeing this is causing some breaks in CI while testing the build forthe example. Do you know why that is? |
|
hmm, I'm not sure why. On local machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the Svelte example to Svelte v5.
It was performed by running
pnpx npm-check-updates -uin all packages inexamples/with-sveltedirectory.Also ran
pnpx sv migrate svelte-5inexamples/with-svelte/packages/ui.Testing Instructions
In
examples/with-svelte, runpnpm devand visitwebanddocssites to verify it's working.This does not impact any automated tests.