Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(signals): prefactor #9995

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

chris-olszewski
Copy link
Member

Description

Prefactors:

  • moved signal listening to own crate
  • return signal received to subscribers
  • support streams instead of single futures for signal sources

PR that prefactors the signals code to prepare for:

  • Subscribers getting all signals sent to turbo
  • Additional signal handlers to be sent transparently to children

There are no behavior changes in this PR. I highly suggest reviewing each commit on its own.

Testing Instructions

Existing unit tests.

Quick manual verification that existing SIGINT behavior remains the same:

$ turbo_dev watch build
...
│    Finalizing page optimization  .   Collecting build traces  .
└────>
  × Watch interrupted due to signal

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 3:15pm

@chris-olszewski chris-olszewski marked this pull request as draft February 18, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant