-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Router] Upstream Fine-Grained Parallel Router (FPT'24) #2920
Draft
ueqri
wants to merge
12
commits into
verilog-to-routing:master
Choose a base branch
from
ueqri:upstream-fpt24-fine-grained-parallel-router
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fd2797f
[Router] Upstream Fine-Grained Parallel Router (FPT'24)
ueqri 875b98e
[ParallelRouter] Removed Boost from FG Parallel Router
AlexandreSinger 03c65f2
Merge branch 'master' into upstream-fpt24-fine-grained-parallel-router
ueqri 25bfd18
[Router] Fix Code Formatting Issues
ueqri 203c738
[Router] Added ConnectionRouter Abstraction and Reduced Code Duplication
ueqri c9e1819
Merge branch 'master' into upstream-fpt24-fine-grained-parallel-router
ueqri fe5cad8
[Router] Added Code Comments and Documentation for Connection Routers
ueqri d07398f
[Router] Fixed Interface Issues in NestedNetlistRouter and Code Formats
ueqri 7e499c7
Merge branch 'master' into upstream-fpt24-fine-grained-parallel-router
ueqri ebc56a3
[Router] Updated Command-Line Usage for Parallel Connection Router
ueqri 19ff0fb
[Router] Added Regression Tests for Parallel Connection Router
ueqri b109d13
Fixed Code Formatting Issue
ueqri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
========== | ||
Connection Router | ||
========== | ||
|
||
ConnectionRouter | ||
--------- | ||
.. doxygenfile:: connection_router.h | ||
:project: vpr | ||
|
||
SerialConnectionRouter | ||
---------- | ||
.. doxygenclass:: SerialConnectionRouter | ||
:project: vpr | ||
|
||
ParallelConnectionRouter | ||
---------- | ||
.. doxygenclass:: ParallelConnectionRouter | ||
:project: vpr |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,4 @@ VPR Router | |
|
||
router_heap | ||
router_lookahead | ||
router_connection_router |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,7 +97,8 @@ static void do_one_route(const Netlist<>& net_list, | |
segment_inf, | ||
is_flat); | ||
|
||
ConnectionRouter<FourAryHeap> router( | ||
// TODO: adding tests for parallel connection router | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this TODO still valid? |
||
SerialConnectionRouter<FourAryHeap> router( | ||
device_ctx.grid, | ||
*router_lookahead, | ||
device_ctx.rr_graph.rr_nodes(), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be confusing and needs more explanation. The queue draining optimization requires the ordering heuriststic (astar fac/offset) to be admissible in order to be deterministic.
The wording above also makes it sound like you can only use this if optimality and determinism is required; however this optimization can be turned on even if you do not care about either of these.