Add a NestedNetlistRouter to enable integration with fine grained parallel router #2924
Conversation
github-actions
bot
added
VPR
duck2
changed the title
duck2
changed the title
| namespace vtr { | ||
|
|
||
| class thread_pool { | ||
| private: |
There was a problem hiding this comment.
Comment every member variable with doxygen and the overall class. I'd give an example of how to use the class in the overall comment.
This should also go into the vtr utility documentation as a new tab eventually.
| std::condition_variable cv; | ||
| bool stop = false; | ||
| size_t thread_id; // For debugging | ||
| size_t tasks_completed{0}; // Track number of completed tasks |
There was a problem hiding this comment.
For logging, or something else?
| std::thread thread; | ||
| std::queue<std::function<void()>> task_queue; | ||
| std::mutex queue_mutex; | ||
| std::condition_variable cv; |
There was a problem hiding this comment.
Shouldn't the name give an idea of what the condition variable controls/is used for, rather than just cv?
| std::atomic<size_t> total_tasks_queued{0}; | ||
| vtr::Timer pool_timer; // Track pool lifetime | ||
| std::atomic<size_t> active_tasks{0}; | ||
| std::mutex completion_mutex; |
There was a problem hiding this comment.
Comment these. (all the variables).
From our discussion: completion_mutex is to wait for all the tasks in the queue to finish.
| std::condition_variable completion_cv; | ||
|
|
||
| public: | ||
| thread_pool(size_t thread_count) { |
There was a problem hiding this comment.
Between the class overview and here, you need to comment how this thread pool works.
vpr/src/route/MixedNetlistRouter.tpp
Outdated
| @@ -0,0 +1,141 @@ | |||
| #pragma once | |||
|
|
|||
| /** @file Impls for ParallelNetlistRouter */ | |||
vpr/src/route/MixedNetlistRouter.h
Outdated
| RouteIterResults route_netlist(int itry, float pres_fac, float worst_neg_slack); | ||
| /** Inform the PartitionTree of the nets with updated bounding boxes */ | ||
| void handle_bb_updated_nets(const std::vector<ParentNetId>& nets); | ||
| void set_rcv_enabled(bool x); |
There was a problem hiding this comment.
Put a comment on set_rcv_enabled that it sets this control variable for each thread (in its local storage).
vpr/src/route/MixedNetlistRouter.h
Outdated
| void handle_bb_updated_nets(const std::vector<ParentNetId>& nets); | ||
| void set_rcv_enabled(bool x); | ||
| void set_timing_info(std::shared_ptr<SetupHoldTimingInfo> timing_info); | ||
|
|
There was a problem hiding this comment.
Same for set_timing_info --> explain it does this for all threads.
vpr/src/route/netlist_routers.h
Outdated
| @@ -71,6 +71,7 @@ class NetlistRouter { | |||
|
|
|||
| /* Include the derived classes here to get the HeapType-templated impls */ | |||
| #include "SerialNetlistRouter.h" | |||
| #include "MixedNetlistRouter.h" | |||
vpr/src/route/netlist_routers.h
Outdated
| @@ -104,6 +105,20 @@ inline std::unique_ptr<NetlistRouter> make_netlist_router_with_heap( | |||
| routing_predictor, | |||
| choking_spots, | |||
| is_flat); | |||
| } else if (router_opts.router_algorithm == e_router_algorithm::MIXED) { | |||
duck2
changed the title
duck2
force-pushed
the
custom-thread-pool
branch
from
dab0030 to
c6a5902
Compare
|
QoR data: custom_thread_pool_5.xlsx So |
|
Looks good. We can merge once the commenting and dead code feedback is addressed / resolved. |
TBB's thread pool doesn't let us block in tasks, so we have to implement a custom thread pool if we want to integrate a parallel netlist router with a parallel connection router.