Update clang-format version to 18 #2945
Merged
+31
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
AmirhosseinPoolad
force-pushed
the
fix_clang_format_version
branch
from
700800e to
62623d3
Compare
AmirhosseinPoolad
force-pushed
the
fix_clang_format_version
branch
from
62623d3 to
1a433b4
Compare
This is the version that is installed by default on Ubuntu 24.04 which we currently run CI and testing on.
AmirhosseinPoolad
force-pushed
the
fix_clang_format_version
branch
from
1a433b4 to
115c6d4
Compare
AmirhosseinPoolad
force-pushed
the
fix_clang_format_version
branch
from
115c6d4 to
1cecbab
Compare
soheilshahrouz
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 24.04 installs clang-format version 18 by default and this PR updates the version used by CI and 'make format' from 14 to 18. Since clang-format 18 is a bit smarter than 14, there were some parts of the code where it fixed some formatting issues that version 14 did not find problematic. The second commit of this PR fixes those issues.