Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid abseil containers with SeqManager compare functions #1369

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Avoid abseil containers with SeqManager compare functions #1369

merged 9 commits into from
Apr 9, 2024

Commits on Apr 9, 2024

  1. Avoid abseil containers with SeqManager compared functions 

    Fixes #1366

### Details

- As demonstrated in temporal PR #1368, standard C++ STD containers do not throw (even in debug mode) when using `Compare` functions in maps/sets that do not honor transitivity, i.e. `comp(a,b) && comp(b,c) -> comp(a,c)`.
- So let's not use abseil containers in those cases.

### Bonus tracks

- Dupicate CI actions in debug mode.
- Make mediasoup Rust building honor `MEDIASOUP_BUILDTYPE` env variable if given.
- Fix an amazing bug in `AudioLevelObserver.cpp` which failed to compile because it uses a `absl::btree_multimap` without including the `absl/container/btree_map.h` header (it didn't fail before due to some absl header included by yet anothe included file, etc).
    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    479e7b1 View commit details
    Browse the repository at this point in the history

  2. fix CI names

    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    6b45209 View commit details
    Browse the repository at this point in the history

  3. Fix wrong set usage

    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3b23846 View commit details
    Browse the repository at this point in the history

  4. don't run mediasoup-rust ci in debug mode in Windows (not supported)

    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5600190 View commit details
    Browse the repository at this point in the history

  5. try again

    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7cf89d0 View commit details
    Browse the repository at this point in the history

  6. more

    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    dd550bb View commit details
    Browse the repository at this point in the history

  7. more

    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3b90b70 View commit details
    Browse the repository at this point in the history

  8. upps

    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    9b5da43 View commit details
    Browse the repository at this point in the history

  9. add a note

    @ibc
    ibc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    53ac4bb View commit details
    Browse the repository at this point in the history