Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-3534 Add last_reconfigured to each resource status #101

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

benjirewis
Copy link
Member

@benjirewis benjirewis commented Oct 24, 2023

RSDK-3534

Updates rust protos (ran make buf). Updates GetReadingRe* use statements. Adds build_time field to LocalRobot derived from gRPC get_config header. Converts build_time to proto and adds that proto to every resource status as last_reconfigured.

Spoke with @gvaradarajan offline. We've added LastReconfigured timestamps to all resources for users of resources to have a better sense of when the resource was last constructed/updated in the backend. The micro RDK has no concept of "reconfiguration" or dynamic updates to resources, so we can just use the time at which we got the cloud config as the build_time for all resources. Note that build_time does not exist for non-cloud LocalRobots, so they'll return None as the last_reconfigured value.

Copy link
Member

@gvaradarajan gvaradarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjirewis benjirewis merged commit 0007bea into viamrobotics:main Oct 25, 2023
4 checks passed
@benjirewis benjirewis deleted the last-reconfigured branch October 25, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants