Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-5805 - support remembering serial port for espflash #140

Merged

Conversation

gvaradarajan
Copy link
Member

Not yet tested, opening PR somewhat prematurely

@gvaradarajan gvaradarajan requested a review from a team as a code owner January 17, 2024 16:50
Copy link
Member

@npmenard npmenard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested with and without the commit. With it asks me if I want to save the port without it doesn't

@gvaradarajan gvaradarajan merged commit 786eccc into viamrobotics:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants