[RSDK-8597] properly respond to signaling request when 'no available connections' #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmenard
requested changes
Sep 16, 2024
micro-rdk/src/common/webrtc/api.rs
Outdated
|
|
||
| sig_channel.send_sdp_error(&sdp).await?; | ||
|
|
||
| // this delay ensures that the sdp error is properly sent and received before closing the connection. |
There was a problem hiding this comment.
can you expand on this? did we confirm 100% it's a race with writing to the MongoDB document?
There was a problem hiding this comment.
Not confirmed yet. Should know tomorrow, will update description and attach a ticket if needed. Wanted to get a first pass done while I wrap that up.
mattjperez
force-pushed
the
rsdk-8597-no-available-connection-errormsg
branch
from
5ea2d25 to
a1cfdaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.