[RSDK-9158] fix key write problem for app address in installer #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmorrow
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
The fix is fine, so LGTM, but:
- The commit message should reference https://viam.atlassian.net/browse/RSDK-9158, which I've just assigned to you and put in progress.
- Please file a follow-up ticket to find a way to re-use the constants from
nvs_storage.rs. It should be a follow-up because right now those constants aren'tpuband the relevant file is esp32 gated so there isn't a way to use them without a bigger refactoring.
gvaradarajan
force-pushed
the
update-installer
branch
from
3dc88f7 to
377d4cb
Compare
gvaradarajan
changed the title
|
Follow-up ticket for refactor here: https://viam.atlassian.net/browse/RSDK-9162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.