[RSDK-9643] ota download timeout #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjperez
commented
Jan 7, 2025
| file_len | ||
| ); | ||
| } | ||
| Ok(None) => break, |
There was a problem hiding this comment.
any issues with an incomplete download should still be caught by the nwritten != content_len check after this scope
mattjperez
commented
Jan 7, 2025
micro-rdk/src/common/ota.rs
Outdated
| .map_err(FrameError::Network) | ||
| .or(async { | ||
| async_io::Timer::after(Duration::from_secs(FRAME_TIMEOUT_SECS)).await; | ||
| Err(FrameError::Timeout(FRAME_TIMEOUT_SECS as usize)) |
There was a problem hiding this comment.
the goal is to timeout if a single frame is unresponsive for more than 30seconds, unblocking the caller (ConfigMonitor) so it can try again completely in 10 seconds (ConfigMonitor's default period)
gvaradarajan
approved these changes
Jan 7, 2025
micro-rdk/src/common/ota.rs
Outdated
| @@ -120,6 +123,15 @@ pub(crate) enum ConfigError { | |||
| Other(String), | |||
| } | |||
|
|
|||
| /// used to differentiate between no-frame and a timeout | |||
| #[derive(Error, Debug)] | |||
| pub(crate) enum FrameError { | |||
There was a problem hiding this comment.
DownloadError instead of FrameError?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.