Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 0.4.1-rc2 due to Cargo.lock issue post-merge for rc1 #391

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

acmorrow
Copy link
Member

@mattjperez and @gvaradarajan - Sorry, we had a race condition on -rc1. I had to merge above #386, but that had a stale reference to 0.4.0 in the lock file:

So we need an -rc2, and this is that change, along with a run of cargo update to make sure that we have all dependencies correct.

Meanwhile, I noticed that we have a Cargo.lock in the project template. @mattjperez and I discussed, and this doesn't make sense to me. We shouldn't be pinning the versions of things in a generated project - that's up to the project maintainer to manage their Cargo.lock, and we aren't well positioned to create a good one for them. The one in the project template was also stale, referring to Micro-RDK 0.3.3: https://github.com/viamrobotics/micro-rdk/blob/main/templates/project/Cargo.lock#L1414.

I've gone ahead and removed it here.

@acmorrow acmorrow requested a review from a team as a code owner January 27, 2025 20:42
Copy link
Member

@gvaradarajan gvaradarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the removal of Cargo.lock from the project template

Copy link
Member

@mattjperez mattjperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran a test check in case, all passing

@acmorrow acmorrow merged commit edec3da into viamrobotics:main Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants