Skip to content

Commit

Permalink
git describe in version string (#13)
Browse files Browse the repository at this point in the history
* remove tflite references

* bump go to 1.23 in base image

* try git describe

* fetch tags?

* depth?

* restore container, describe in right place
  • Loading branch information
abe-winter authored Nov 11, 2024
1 parent 99f73fb commit 50570aa
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jobs:
repository: ${{ inputs.repository || 'viamrobotics/rdk' }}
ref: ${{ inputs.ref }}
path: rdk
fetch-depth: 1000 # this is to make `git describe` work
fetch-tags: true
- name: extract keystore
# we do this so CI builds have consistent signing. otherwise you cannot `adb install` without uninstalling first
env:
Expand All @@ -49,7 +51,7 @@ jobs:
run: |
mkdir ../dist
source $SDKMAN_DIR/bin/sdkman-init.sh
export APK_VERSION_SUFFIX=-$(date +%y%m%d)-$(cd ../rdk && git rev-parse --short HEAD)-$(git rev-parse --short HEAD)
export APK_VERSION_SUFFIX=-$(date +%y%m%d)-$(cd ../rdk && git describe --tags)-$(git rev-parse --short HEAD)
# todo(review): is it safe to use gradle in path instead of gradlew? or way to make gradlew use system gradle?
RDK_PATH=$(realpath ../rdk/droid-rdk.arm64.aar) gradle --no-daemon assembleDebug
mv app/build/outputs/apk/debug/app-debug.apk \
Expand Down

0 comments on commit 50570aa

Please sign in to comment.