Migrated project to AndroidX #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thanks for creating Floral! It's a really nice gallery app!
Summary
This PR contains a version of the code, migrated to AndroidX.
About
When attempting to launch the app installed from F-Droid, I was experiencing some crashes at first - considering logcat, this seems to be due to vital resources being stripped out of the apk at build time (probably by proguard). Trying to compile the app I noticed, I was actually unable to create a successful build from the latest code on
masterdue to a lot of 'class not found' errors.Eventually I managed to fix that by migrating most parts of the project to using
androidxrather than the legacysupportlibrary, using the approach described here.So far I did not notice any trouble when running the migrated app. The resulting build has the
enableJetifieranduseAndroidXsettings enabled and requires much fewer manualimplementationstatements to the legacysupportlibrary inbuild.gradle.Note though(!) that I did not take the time to migrate the proguard rules. Since the current ones were causing troubles, I have commented them out in this commit.
Result
I'd like to offer the migration I did as a PR. Since the migration includes renaming most class names to their respective names in the
androidx.namespace, the main commit involves a lot of changes, certainly.However it might be a necessary step, since it appears like with the current version of android SDK (whatever ever changed), it seems like the previous version of the code cannot be built out of the box anymore.
Other fixes in this PR
gradlew(linux and macOS)