-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pH and turbidity sensors to ensure safe drinking water. #320 #372
base: develop
Are you sure you want to change the base?
Conversation
…ntation Added FAQs and resources
…ation Added FAQs + Mentors for GSSoC 2020
…ation Added branching info
…ation Updated README.md
…erfest Add Hacktoberfest in README.md
In demo.html: added a function to check pH and turbidity for reference only. It only console.logs the result also added arduino and nodemcu files for the IOT work of pH and turbidity sensor
Thanks for opening this pull request! 🤗 📢 Spread the word about @vinitshahdeo/Hacktoberfest2020 repo across your social media channels to help get others involved! Give a shoutout to Check out few other repos below 🚀 Show some ❤️
Say Hi on Twitter! 👋PS: Please add @vinitshahdeo as a reviewer if you haven't added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please send the PR to the develop branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed to merge with develop
@nandikajain I don't understand the conflicts! The above conflicting files were not changed by me, I had only added a sample function in home.html and that was also only printing in the console. I removed that too but still there is conflict showing. Could you please re-review. |
I do not review the PR's for IoT. I review for the frontend. I will tag the concerned person! Hope that helps. @roypratik |
Could you please ask the concerned person to review it. I wanted to do multiple PR in SWOC 20! |
|
Description
Added pH and turbidity checker for issue no #320
added arduino and nodeMCU files and also created a reference script in demo.html which only console.logs the result
Fixes # (issue)
fixes the issue #320
Type of change
Please delete options that are not relevant.
Checklist:
Reviewer: Vinit Shahdeo