Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for a difference in the hip positions of the avatar and animation model. #130

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

Gigabyte5671
Copy link
Member

@Gigabyte5671 Gigabyte5671 commented Feb 7, 2023

Short avatars will no longer appear to float, and tall avatars will no longer appear to clip into the ground.
image

These offsets were cancelling each other out.
…tion model

Short avatars will no longer appear to float, and tall avatars will no longer appear to clip into the ground.
Copy link
Contributor

@ctrlaltdavid ctrlaltdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also resolve the differences in avatar elevations between native and Web clients - #126 ?

src/modules/scene/resource.ts Outdated Show resolved Hide resolved
src/modules/scene/resource.ts Outdated Show resolved Hide resolved
src/modules/scene/resource.ts Outdated Show resolved Hide resolved
src/modules/scene/vscene.ts Show resolved Hide resolved
@Gigabyte5671
Copy link
Member Author

Does this also resolve the differences in avatar elevations between native and Web clients - #126 ?

Unfortunately, this PR doesn't fix #126. I'm still seeing this in the web client:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants