Account for size of token replacements when sizing the bar #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are not doing this, then the bar can overflow to the next line, then it starts drawing itself over and over again, because the start of the line is not the real start of the line but the start of the wrapped line, and that is really annoying... Since we want the bar size to remain stable, the maximum size for a token is remembered.
And ignore replacements that aren't appearing in the template
|
@FremyCompany Can you file an issue at TensorFlow.js' Issues page with details on the model you are using? |
|
@caisq Sure. This would happen for any model that has a few outputs/metrics. |
|
@FremyCompany Got it. I think I know what the problem is, but will appreciate you filing an issue formally regardless. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are not doing this, then the bar can overflow to the next line, then it starts drawing itself over and over again, because the start of the line is not the real start of the line but the start of the wrapped line, and that is really annoying...
Since we want the bar size to remain stable, the maximum size for a token is remembered.