-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-vite): support auto install dependencies and start dev #12248
base: main
Are you sure you want to change the base?
Conversation
|
I tried this locally, by:
And it looks like the auto-install didn't kick in (I choose Vue -> Typescript) 🤔 |
Oh, scratch that. It worked, but I expected to see a lock file and not only node_modules. Also, I will navigate into the folder automatically and start the app (like in sli.dev) Have you seen this issue and PR @sun0day? |
Nooo... I didn't search that. But this is exactly what I want to add to vite. My pr is still a draft, I'd like to discuss with the team about whether this is a valuable enhancement first. BTW, why was that pr closed ? |
I think it would be better to keep working on the PR to have the complete flow in this case. I don't know why the PR was closed to be honest, maybe you could check out the code and see if the implementation could be used as a base (also checking the implementation in sli.dev that seems to be working well) |
ok. but here is a small problem, I see that I implemented an initial version. @patak-dev cc |
a360c72
to
ff062e3
Compare
In the last meeting (which happened in a very long time ago but we didn't give an update sorry 😬), we agree that this would be nice to have. We just need someone to review and rebase the PR. |
Description
boolean
)string
)Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).