fix: use nodeLikeBuiltins
for ssr.target: 'webworker'
without noExternal: true
#19313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the
Cannot bundle Node.js built-in
error was only shown whennoExternal: true
is set.https://github.com/vitejs/vite/pull/18584/files#diff-9b81bb364c02eab9494a7d27a5effc400cacbffd3b8f349c192f890c37bfc83fL429-L445
To align with that, this PR sets
nodeLikeBuiltins
by default forssr.target: 'webworker'
withoutnoExternal: true
.This should fix the ecosystem-ci failure of waku: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/13024909071/job/36332279608
refs #18584