Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use nodeLikeBuiltins for ssr.target: 'webworker' without noExternal: true #19313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sapphi-red
Copy link
Member

Description

Previously the Cannot bundle Node.js built-in error was only shown when noExternal: true is set.
https://github.com/vitejs/vite/pull/18584/files#diff-9b81bb364c02eab9494a7d27a5effc400cacbffd3b8f349c192f890c37bfc83fL429-L445
To align with that, this PR sets nodeLikeBuiltins by default for ssr.target: 'webworker' without noExternal: true.

This should fix the ecosystem-ci failure of waku: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/13024909071/job/36332279608

refs #18584

@sapphi-red sapphi-red added this to the 6.1 milestone Jan 29, 2025
@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 29, 2025
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

Copy link

pkg-pr-new bot commented Jan 29, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vite@19313

commit: 4fcd66f

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 4fcd66f: Open

suite result latest scheduled
astro failure failure
histoire failure failure
nuxt failure failure
qwik failure failure
redwoodjs failure failure
vitest failure failure
waku success failure

analogjs, ladle, laravel, marko, previewjs, quasar, rakkas, react-router, storybook, sveltekit, unocss, vike, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) trigger: preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant