Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): add cssExtract option to build config (#4345) #6569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JackFGreen
Copy link

Description

Add cssExtract option.
When building as a library, you can also set this to false to avoid your users having to import the CSS themselves, like vue-cli css.extract

fix #4345


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Djaler
Copy link

Djaler commented Mar 9, 2022

I published this in my fork: @djaler/[email protected]

@bluwy
Copy link
Member

bluwy commented Mar 9, 2022

Looks there are failing tests before it can be reviewed.

@Djaler
Copy link

Djaler commented Jun 13, 2022

@JackFGreen can you update this?

@JackFGreen
Copy link
Author

@JackFGreen can you update this?

@Djaler updated, check the new version

@bluwy bluwy added the p2-to-be-discussed Enhancement under consideration (priority) label Jun 25, 2022
@seahindeniz
Copy link

@JackFGreen there's a failed test that might require your attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css feat: library mode p2-to-be-discussed Enhancement under consideration (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extract css false option in lib build mode
5 participants