Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: beautify the source maps #7505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: beautify the source maps #7505

wants to merge 1 commit into from

Conversation

smallp
Copy link

@smallp smallp commented Mar 29, 2022

Description

Move source maps to source-maps://.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 29, 2022
@sapphi-red
Copy link
Member

Could you add the same logic here for css sourcemaps?

const sourcemap = this.getCombinedSourcemap()
await injectSourcesContent(sourcemap, cleanUrl(id), config.logger)
return getCodeWithSourcemap('css', content, sourcemap)

@smallp
Copy link
Author

smallp commented May 19, 2022

@sapphi-red
I don't believe we need to do that.
All requests would call transformRequest where I add namespace here. So we don't have to add it again.

@sapphi-red
Copy link
Member

transformRequest won't be called for css dev sourcemaps because the source maps for them are inlined.

@smallp
Copy link
Author

smallp commented May 19, 2022

Got it. Done.

@smallp smallp reopened this Sep 19, 2022
@smallp
Copy link
Author

smallp commented Sep 19, 2022

@sapphi-red Rebased. And who can review it? It is months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate Source Maps' files from real files via namespace
4 participants