test: fix flaky browser-multiple.test.ts #7510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
requested changes
Feb 18, 2025
| @@ -11,6 +11,9 @@ it('automatically assigns the port', async () => { | |||
| onTestFinished(() => spy.mockRestore()) | |||
| let ctx: Vitest | |||
| let urls: (string | undefined)[] = [] | |||
| // override default port since it can conflicts with | |||
| // other browser mode tests in test/cli suite | |||
There was a problem hiding this comment.
test/cli runs sequentially, they should not affect each other
There was a problem hiding this comment.
I don't think it's sequential. I noticed config has thread options
vitest/test/cli/vitest.config.ts
Lines 8 to 12 in 25e6fe8
Is this meant to be singleFork? or fileParallelism: false is fine?
There was a problem hiding this comment.
Yes, it's supposed to make tests run sequentially
sheremet-va
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one keeps failing, so I added a quick workaround.Fixed by makingtest/clisequential withsingleForkPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.