Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake build system #17

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ProExpertProg
Copy link

@ProExpertProg ProExpertProg commented Aug 23, 2024

Added a CMake-based build system to enable building this package from source in the vLLM build. That will allow using PyTorch nightly, which is needed by the torch.compile and another project in vLLM.

Heavily inspired by the new build system in vLLM.

setup.py Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@ProExpertProg ProExpertProg marked this pull request as ready for review August 26, 2024 15:20
Copy link

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment in the test file.

Copy link

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the python finding code first time.

@ProExpertProg ProExpertProg marked this pull request as draft September 10, 2024 21:07
@ProExpertProg
Copy link
Author

(marking as draft until I resolve the binary size/arch explosion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants