Add pipeline parallel support to TransformersModel
#12832
Conversation
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Harry Mellor <[email protected]>
| log_replacement("input embedding", self.model.get_input_embeddings(), | ||
| new_module) | ||
| self.model.set_input_embeddings(new_module) | ||
| def init_buffers(self, module: nn.Module): |
There was a problem hiding this comment.
General comment, might it be better to move this function to a separate transformers_utils file?
There was a problem hiding this comment.
We could, but I worry that would pollute the models directory
| for child in module.children(): | ||
| self.init_buffers(child) | ||
|
|
||
| def meta_to_empty(self, module: nn.Module): |
There was a problem hiding this comment.
Same, might it be better to move this function to a separate transformers_utils file?
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
|
This pull request has merge conflicts that must be resolved before it can be |
|
Can only be merged after Transformers v4.49, but marking as ready for review so this can be merged soon after. |
Depends on changes made by huggingface/transformers#36091.
Tested with Llama 3.1 70B in pp=4 and pp2,tp2 configurations.
The following command can be used for testing: