Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Use msgpack for core request serialization #12918

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

njhill
Copy link
Member

@njhill njhill commented Feb 7, 2025

We were using pickle rather than msgpack for serializing the messages from the front-end process to the engine, because msgpack doesn't natively support tensors and these need to be included for multimodal requests.

These can be handled easily though via custom msgpack extension. This should mean more efficient serialization.

This PR also simplifies handling of different request types.

Copy link

github-actions bot commented Feb 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 7, 2025
We were using pickle rather than msgpack for serializing the messages from the front-end process to the engine, because msgpack doesn't natively support tensors and these need to be included for multimodal requests.

These can be handled easily though via custom msgpack extension. This should mean more efficient serialization.

This PR also simplifies handling of different request types.

Signed-off-by: Nick Hill <[email protected]>
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 7, 2025
@njhill njhill marked this pull request as ready for review February 7, 2025 21:30
@njhill njhill removed the ready ONLY add when PR is ready to merge/full CI is needed label Feb 7, 2025
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant