[Misc] Log time consumption on weight downloading #12926
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
waltforme
force-pushed
the
log-downloading
branch
from
ea49c5d to
79171f0
Compare
| @@ -262,6 +266,11 @@ def download_weights_from_hf( | |||
| revision=revision, | |||
| local_files_only=huggingface_hub.constants.HF_HUB_OFFLINE, | |||
| ) | |||
| end_time = time.time() | |||
There was a problem hiding this comment.
Better to use perf.counter() or monotonic() instead.
Signed-off-by: Jun Duan <[email protected]>
waltforme
force-pushed
the
log-downloading
branch
from
79171f0 to
23f62ea
Compare
This PR tries to give some visibility to the time used on downloading weights from HF.
This tiny feature allows us to quantitatively understand the performance gain of local cache, thus can greatly help us to evaluate (and optimize) the performance of the engine.
FIX #12916