Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Optionally remove memory buffer used for uploading to URLs in run_batch #12927

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pooyadavoodi
Copy link
Contributor

We also retry a few times in case an exception (e.g. timeout) happens during the upload.

We also retry a few times in case an exception (e.g. timeout) happens
during the upload.

Signed-off-by: Pooya Davoodi <[email protected]>
Copy link

github-actions bot commented Feb 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 8, 2025
@pooyadavoodi pooyadavoodi changed the title [Frontend] Optionally remove memory buffer used for uploading to URLs [Frontend] Optionally remove memory buffer used for uploading to URLs in run_batch Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant