Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Clarify input processing and multimodal feature caching logic #13211

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Feb 13, 2025

As we open up V1 interface to community developers, IMO it's important to have a good level of documentation clarity in terms of code logic.

Since there has been good progress in #10114, this PR cleans up and adds clarifications on input processing and multimodal feature caching logic so that it's easier for new developers to get a high-level read without diving into the details of each component.

Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Roger Wang <[email protected]>
@mergify mergify bot added the v1 label Feb 13, 2025
Signed-off-by: Roger Wang <[email protected]>
@ywang96 ywang96 marked this pull request as ready for review February 13, 2025 08:47
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 13, 2025 08:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 13, 2025
@simon-mo simon-mo merged commit fdcf64d into main Feb 13, 2025
48 of 58 checks passed
@simon-mo simon-mo deleted the mm-v1-cleanup branch February 13, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants