This repository has been archived by the owner on Jul 15, 2021. It is now read-only.
Add Identity Provider CA to kubeconfig #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables usage of self signed cert for the IdP by providing a config `idpCAPath` in the config map. Closes: vmware-archive#148 Signed-off-by: Vijay Katam <[email protected]>
vijaykatam
commented
Feb 11, 2020
| @@ -63,7 +63,8 @@ kubectl config set-credentials "{{ .KubeCfgUser }}" \ | |||
| --auth-provider-arg='client-id={{ .ClientID }}' \ | |||
| --auth-provider-arg='client-secret={{ .ClientSecret }}' \ | |||
| --auth-provider-arg='refresh-token={{ .RefreshToken }}' \ | |||
| --auth-provider-arg='id-token={{ .IDToken }}' | |||
| --auth-provider-arg='id-token={{ .IDToken }}' \ | |||
| --auth-provider-arg='idp-certificate-authority-data={{ .IdentityProviderCA }}' \ | |||
There was a problem hiding this comment.
If idp-certificate-authority-data is empty it is ignored.
Signed-off-by: Vijay Katam <[email protected]>
jenting
reviewed
Mar 10, 2020
| if cfg.IdentityProviderCAPath != "" { | ||
| caFile, err := os.Open(cfg.IdentityProviderCAPath) | ||
| if err != nil { | ||
| log.Errorf("Failed to open CA file. %s", err.Error()) |
There was a problem hiding this comment.
Suggested change
| log.Errorf("Failed to open CA file. %s", err.Error()) | |
| log.Errorf("Failed to open CA file. %s", err) |
| defer caFile.Close() | ||
| idpCA, err := ioutil.ReadAll(caFile) | ||
| if err != nil { | ||
| log.Errorf("Could not read CA file: %s", err.Error()) |
There was a problem hiding this comment.
Suggested change
| log.Errorf("Could not read CA file: %s", err.Error()) | |
| log.Errorf("Could not read CA file: %s", err) |
Comment on lines
+302
to
+304
| log.Errorf("Could not read CA file: %s", err) | ||
| http.Error(w, "Could not read CA file", http.StatusInternalServerError) | ||
| return nil |
There was a problem hiding this comment.
This change make go test failed. Consider leave it as it was or update the testing code.
|
|
||
| # The path to find the CA bundle for the IdP, optional. Used to configure kubectl. | ||
| # Env var: GANGWAY_IDP_CA_PATH | ||
| # idpCAPath: "/cacerts/idpca.cert" |
There was a problem hiding this comment.
configuration doc should be updated also.
|
From my point of view, IdentityProviderCA is the same as TrustedCAPath since it should both points the same server, am I right? If yes, then all we have to do is embed the |
|
Any plans to finish this PR? |
|
Hey @vijaykatam would you mind rebasing this as well as looking at the comments + failing tests? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables usage of self signed cert for the IdP by providing
a config
idpCAPathin the config map.Signed-off-by: Vijay Katam [email protected]
Closes: #148