This repository has been archived by the owner on Jul 15, 2021. It is now read-only.
updated readme.md #173
Open
updated readme.md #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced referenced to heptio contour by Project Contour also replaced link to helption contour github page by link to Project Contour.
stevesloka
suggested changes
Oct 1, 2020
docs/README.md
Outdated
| @@ -6,7 +6,7 @@ How you provide access to the service is going to be dependent on your specific | |||
|
|
|||
| A good starting point for yaml manifests for deploying to Kubernetes is in the [yaml](./yaml) directory. | |||
| This creates a namespace, configmap, deployment and service. | |||
| There is also an example ingress config that is set up to work with [Heptio Contour](https://github.com/heptio/contour), [JetStack cert-manager](https://github.com/jetstack/cert-manager) and [Let's Encrypt](https://letsencrypt.org/). | |||
| There is also an example ingress config that is set up to work with [Project Contour](https://github.com/projectcontour/contour), [JetStack cert-manager](https://github.com/jetstack/cert-manager) and [Let's Encrypt](https://letsencrypt.org/). | |||
| See [Dave Cheney's blog post](https://blog.heptio.com/how-to-deploy-web-applications-on-kubernetes-with-heptio-contour-and-lets-encrypt-d58efbad9f56) for an example of getting all of that configured. | |||
There was a problem hiding this comment.
Maybe swap out Dave's link for this guide which is kept more up to date: https://projectcontour.io/guides/cert-manager/
stevesloka
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
/lgtm
Can you sign the 2nd commit @pbisen to make the DCO bot happy?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced referenced to heptio contour by Project Contour
also replaced link to heptio contour github page by link to Project Contour.