-
Notifications
You must be signed in to change notification settings - Fork 442
Enhance Config (.kubewatch.yaml) for granular alerting #176
base: master
Are you sure you want to change the base?
Conversation
@tylerauerbeck, @jbianquetti-nami, @jjo |
d91152c
to
3aea0cb
Compare
We could discuss on this feature (when people are free) for improvements like,
Altering the current config suitably, would support customisation. |
3aea0cb
to
9ccc625
Compare
def want this + label selectors to further target specific things to monitor |
Remider Ping |
FYI, These features are now avalilable with Botkube (0.9.0) |
Botkube lack other features (like Teams integration), i hope that this PR will be merged since i think that it will be useful for a lot of users: now even on small k8s deployment, a small activity like a deployment or a scaleup, create a lot of notifications (6 or more) ... this makes the notifications unreadable and mute-prone |
9ccc625
to
dc52701
Compare
rebased into master |
conflicts |
dc52701
to
706daf8
Compare
resolved conflicts and rebased into the master |
706daf8
to
ae487a8
Compare
@mkmik rebased into master |
This commit - Adds "Event" config section in the .kubewatch.yaml file for granular alerting - Makes Event config optional - Makes Resource config optional for backward compatibility - Enables configuration of alerts either using the "Resource" config or "Event" Config - Renames "Services" option to "Service" option in .kubewatch.yaml file - Populates Namespace details from events key, if the Namespace filed is empty Upon Merging - Enables the user to customize alerts based on the Event configuration provided. eg: pod - alerts on creation and deletion events can be configured. svc - alerts on deletion can be configured individually.
ae487a8
to
7dac109
Compare
config/config.go
Outdated
Resource Resource `json:"resource"` | ||
|
||
// For watching specific namespace, leave it empty for watching all. | ||
Resource Resource `json:"resource,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that in your rebase+conflict resolutions you reverted the comments.
in #233 I added a feature that generates a "sample" configuration file annotated with doc comments:
$ kubewatch config sample
For this to work, the Config
Go type (and all structs used for its value) must have meaningful comments, following the godoc rules, namely if a comment directly precedes a field declaration, it's considered a field documentation comment.
this is why the commented out //Reason..
statement has been separated from the Resource
field by an empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you be specific about the change to correct this
This commit, - attempts to resolve the reviews - replaces Service with Services to follow convention
Any news on this? |
This PR
Upon Merging
eg:
pod - alerts on creation and deletion events can be configured.
svc - alerts on deletion can be configured individually.
Example Configs:
Using Resource Config:
Using Resource Config Sends all events to the specified channel.
Note: This section is kept unchanged for backward compatibility.
Using Event Config:
Using Event Config
will be sent to the specified channel.
This PR addresses Issue #105 and #163.
I would like to discuss on this PR and get it merged with peer reviews and feedbacks.