AV-232413 : Encode pg and pool name in SNI mode for ingress/route host with no path defined #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DixitAakash
requested review from
arihantg,
akshayhavile,
pkoshtavmware and
ashishnayak96
|
build ako |
…t with no path defined
arihantg
approved these changes
Mar 20, 2025
| g.Expect(node.HttpPolicyRefs[1].RedirectPorts[0].Hosts[0]).To(gomega.Equal("foo.com")) | ||
|
|
||
| integrationtest.TeardownHostRule(t, g, vsKey, hrname) | ||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
Instead of using sleep, can we use eventually to address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the underlying issue seen in the following bugs https://vmw-jira.broadcom.net/browse/AV-232211 and https://vmw-jira.broadcom.net/browse/AV-232413.
The primary issue is that If an ingress/route does not specify a path in spec, and the corresponding hostrule has useRegex field set to true, the PG name in httppolicyset is not being encoded for the empty path in SNI mode. This leads to httppolicyset creation failure as the actual pg and pools are re-created with encoded names, but httppolicyset tries to use the old not encoded pg name.