Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove golangci-lint parameters which are unsupported #1507

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ksamoray
Copy link
Collaborator

skip-pkg-cache and skip-build-cache has been removed in v6.x version of golangci-lint, and therefore removed from config. See here:
https://github.com/golangci/golangci-lint-action/blob/master/README.md#compatibility

This will suppress the warning below from golangci-lint execution:

Unexpected input(s) 'skip-pkg-cache', 'skip-build-cache', valid inputs are ['version', 'install-mode', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-save-cache', 'problem-matchers', 'args', 'cache-invalidation-interval']

skip-pkg-cache and skip-build-cache has been removed in v6.x version of golangci-lint, and therefore removed from config.
See here:
https://github.com/golangci/golangci-lint-action/blob/master/README.md#compatibility

Signed-off-by: Kobi Samoray <[email protected]>
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Those must have snuck back in on the rebase yesterday.

@ksamoray
Copy link
Collaborator Author

@tenthirtyam @annakhm I also consider disabling cache on setup-go due to the following warning:

Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2

and per the following issue:
actions/setup-go#403

What's your opinion about?

@tenthirtyam
Copy link
Collaborator

Interesting! I've not seen that happen in other projects but I'd support adding cache: false to the with section.

To avoid warnings when tar fails

Signed-off-by: Kobi Samoray <[email protected]>
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Kobi!

@annakhm
Copy link
Collaborator

annakhm commented Jan 16, 2025

@tenthirtyam @annakhm I also consider disabling cache on setup-go due to the following warning:

Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2

and per the following issue: actions/setup-go#403

What's your opinion about?

We've seen jobs time out, but I'm not sure if disabling cache will increase those occurrences. We can certainly try

@tenthirtyam tenthirtyam merged commit 8450240 into vmware:master Jan 16, 2025
5 checks passed
@ksamoray ksamoray deleted the golangci-lint-params branch January 21, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants