add authextra into session meta info #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
In my app I use Thruway router and I’ve implemented server-side wamp client subscriber for meta events like on_join/on_leave. In event handlers of such events, I’d like to use client’s info such as IP, user-agent, header and so on for save that info into redis. So for transfer such kind of data I want to use authExtra from authenticationDetails.
I’ve already found a workaround without any library changes. I’ve overridden Session::getMetaInfo() method and also overridden method Router::createNewSession() in subclasses. But I think it would be great if the library will support extra auth data in meta events out of box.