Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rpgf 4 banner and fix favicon #479

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

yitongzhang
Copy link
Contributor

@yitongzhang yitongzhang commented Sep 2, 2024

Improve favicon

before: chunky, does not work in dark mode, gets cropped by arc browser

CleanShot 2024-09-02 at 16 12 44@2x

after: very demure, very mindful

CleanShot 2024-09-02 at 16 13 36@2x

by the way, am i crazy or does the agora-next app not explicitly define favicon? @andreitr tagging you to make sure i didn't mess up lol

Remove banner

CleanShot 2024-09-02 at 16 00 57@2x

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agora-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:24pm
agora-next-cyber ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:24pm
agora-next-ens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:24pm
agora-next-etherfi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:24pm
agora-next-scroll ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:24pm
agora-next-uniswap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:24pm
scroll-claim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:24pm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just looks like a big black square, is it supposed to be the favicon?

Copy link
Collaborator

@mcgingras mcgingras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm lets gooo

@yitongzhang yitongzhang merged commit dd5639a into main Sep 4, 2024
10 checks passed
@yitongzhang yitongzhang deleted the yitong/remove-rpgf4-banner branch September 4, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants