Scroll gov site improvements #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jefag
approved these changes
Sep 19, 2024
jefag
reviewed
Sep 19, 2024
|
|
||
| const { contracts } = Tenant.current(); | ||
| const { contracts, ui } = Tenant.current(); | ||
| const shouldHideAgoraBranding = ui.hideAgoraBranding; |
There was a problem hiding this comment.
Maybe consider flipping the language and the flag.
ie shouldHaveAgoraBranding.
And then the setting should be false for when it's not wanted, and true by default.
Edit: spelling
There was a problem hiding this comment.
for me this makes sense because we don't even need to add a default -- if the tenant does not have this flag set, it will be undefined, which will be false, so it's default false. Then, if you want to hide, you have to go through the work of setting a flag.
happy to change though if the other way around makes sense to majority of other folks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nits suggested by scroll team.