Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $hostinterfaceitem to not be an Fqdn. #726

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bjschafer
Copy link

Pull Request (PR) description

As per #725 and the upstream documentation, zabbix::agent::hostinterfaceitem should not be an FQDN as it refers to a Zabbix item.

I did not set a type, to match the similar $hostmetadataitem. Let me know if I should instead set it to be something like Optional[String].

This Pull Request (PR) fixes the following issues

Fixes #725

Braxton Schafer added 2 commits October 29, 2020 16:15
As per the upstream documentation
(https://www.zabbix.com/documentation/5.0/manual/appendix/config/zabbix_agentd),
hostinterfaceitem should be a Zabbix item and NOT an FQDN.

Closes voxpupuli#725
* gh/master:
  Fix $hostinterfaceitem to not be an Fqdn.
@bastelfreak bastelfreak added the bug Something isn't working label Jan 18, 2021
@bastelfreak
Copy link
Member

Hi @bjschafer, thanks for the PR. please take a look at the inline comment I made and also rebase against our latest master branch. can you please add a test that checks that it passes with a string that's not an fdqn? Otherwise I'm afraid in the future people might add the fqdn type again.

@bastelfreak
Copy link
Member

@bjschafer can you please rebase against our current master branch and squash the commits?

add test to fail if hostinterfaceitem is set to fqdn
@vox-pupuli-tasks
Copy link

Dear @bjschafer, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@Valantin
Copy link
Contributor

hi @bjschafer can you update this PR with information provided in #953 otherwise I can reimplement it in a new PR

@Valantin Valantin added this to the 11.0.0 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zabbix::agent::hostinterfaceitem not respected
3 participants