Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customElement): support attachInternals method #12129

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #10948

Copy link

github-actions bot commented Oct 8, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+185 B) 38 kB (+54 B) 34.3 kB (+36 B)
vue.global.prod.js 158 kB (+185 B) 57.9 kB (+51 B) 51.5 kB (+60 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.2 kB 16.6 kB
createApp 54.3 kB 21.2 kB 19.3 kB
createSSRApp 58.5 kB 22.9 kB 20.9 kB
defineCustomElement 59.3 kB (+124 B) 22.8 kB (+54 B) 20.8 kB (+102 B)
overall 68.4 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12129

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12129

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12129

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12129

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12129

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12129

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12129

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12129

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12129

vue

npm i https://pkg.pr.new/vue@12129

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12129

commit: 4e90c41

@lejunyang
Copy link

Should we also create a new API like useHostInternals()? As _internal seems to be a private field

@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 deleted the edison/feat/ce_attachInternals branch October 21, 2024 07:35
@edison1105 edison1105 restored the edison/feat/ce_attachInternals branch October 21, 2024 08:26
@edison1105 edison1105 reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom elements not able to associate with form
2 participants