Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): avoid marking PropType<boolean> as undefined in props #12326

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Nov 5, 2024

close #8852

Copy link

github-actions bot commented Nov 5, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 21 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Nov 5, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12326

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12326

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12326

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12326

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12326

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12326

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12326

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12326

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12326

vue

pnpm add https://pkg.pr.new/vue@12326

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12326

commit: 96b0dc2

@jh-leong
Copy link
Member Author

jh-leong commented Nov 5, 2024

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Nov 5, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success failure
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types labels Nov 5, 2024
@jh-leong jh-leong removed the ready to merge The PR is ready to be merged. label Nov 5, 2024
@jh-leong
Copy link
Member Author

jh-leong commented Nov 5, 2024

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Nov 5, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant failure success
vite-plugin-vue success failure
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure success
vueuse success success
vue-simple-compiler success success

@jh-leong
Copy link
Member Author

jh-leong commented Nov 5, 2024

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Nov 5, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success failure
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@jh-leong jh-leong marked this pull request as draft November 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prop boolean required type error
3 participants