Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-vapor): properly mount template-only components in production #12727

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jan 16, 2025

this playground is not working in PROD mode, because of the Comp.vue doesn't has setup

@edison1105 edison1105 added the scope: vapor related to vapor mode label Jan 16, 2025
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 362b3bc
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/6799ae41ef3d910008f4e100
😎 Deploy Preview https://deploy-preview-12727--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edison1105 edison1105 changed the title fix(runtime-vapor): properly mount component only with template in production mode fix(runtime-vapor): properly mount template-only components in production Jan 16, 2025
@yyx990803 yyx990803 merged commit 568e824 into vapor Jan 29, 2025
10 of 11 checks passed
@yyx990803 yyx990803 deleted the edison/fix/renderSimpleComponentInProd branch January 29, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants